nextpnr-xilinx: init at 0.5.0 - #257737
Closed
jleightcap wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Jack Leightcap <jack@leightcap.com>
Contributor
|
@jleightcap This is not necessarily blocked by the missing fasm. |
Contributor
Author
|
ah sorry, poor wording, more specifically this is blocked on adding yourself as
the maintainer as in
3156581.
if you'd like you can open a separate PR to add yourself as a maintainer.
…On Wed Sep 27, 2023 at 10:49 PM EDT, Hans Baier wrote:
This is not necessarily blocked by the missing fasm. The user always could
easily install fasm locally with pip.
|
wegank
marked this pull request as draft
July 15, 2024 11:56
wegank
reviewed
Jul 15, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
CC @hansfbaier
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)